-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) in Overkiz integration #95706
Conversation
Hey there @iMicknl, @vlebourl, @tetienne, @nyroDev, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This PR was tested on my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes to start with. I am not a huge fan of the _global_control()
function, I think it can be simplified. Or otherwise split between OVP and HLRRWIFI if they are significant different.
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
12e1b90
to
a6eb155
Compare
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Have you well tested the behavior using your own device?
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
Hello @dotvav, When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es). The commits that are missing a linked GitHub account are the following:
Unfortunately, we are unable to accept this pull request until this situation is corrected. Here are your options:
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community. Thanks, I look forward to checking this PR again soon! ❤️ |
This PR now includes only the devices on the HLRRWIFI protocol. It has been eby myself on my device, and 2 other users. I will make a separate PR for the devices on the OVP protocol when they have been succesfully tested end to end. |
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump_hlrrwifi.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 2 minor comments, and please rebase. Such a complex device, but happy that it works well and code is understandable.
FAN_SILENT: OverkizCommandParam.SILENT, | ||
} | ||
|
||
# We need to make all state strings lowercase, since Hi Kumo server returns capitalized strings for some states. (without a clear pattern) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# We need to make all state strings lowercase, since Hi Kumo server returns capitalized strings for some states. (without a clear pattern) |
Seems the code that this comment was describing is not present anymore.
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump_hlrrwifi.py
Outdated
Show resolved
Hide resolved
58f2e1e
to
d9f2740
Compare
Proposed change
Add support for the HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) climate entity, ported from
https://github.com/iMicknl/ha-tahoma/blob/master/custom_components/tahoma/climate_devices/hitachi_air_to_air_heat_pump.py.
Fixes #85781
This PR is a continuation of #81743 to passe mypy and fix bugs.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: