-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Early Access versions of UniFi Protect and Warn User #81758
Conversation
Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I think we could raise a different repair issue if the setup fails on ea |
I'm pretty comfortable with this now. I think its ready for tests |
Still fighting with the cloud key to get it updated to EA |
I've got the cloudkey factory reset now and running I'm updating protect to 2.6.17 to test this |
Found an issue in testing but its not related to this change #82041 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing looks good 👍
Thanks @AngellusMortis |
Proposed change
Since UniFi Protect does not have an open API, an Early Access version of Protect can have a breaking change at any time causing the HA integration to break. The repair system can be used to have the user to acknowledge the risk of using EA versions.
Warning repair you get for running EA:
If you submit while still running EA, second warning:
If an error occurs during startup while running EA, the above Repair will be deleted and replaced with:
(note:
Error: test
is thestr(Exception)
, I only had just didraise Exception("test")
so that is why it is kind of bland.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: