Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Early Access versions of UniFi Protect and Warn User #81758

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Detect Early Access versions of UniFi Protect and Warn User #81758

merged 4 commits into from
Nov 13, 2022

Conversation

AngellusMortis
Copy link
Contributor

@AngellusMortis AngellusMortis commented Nov 8, 2022

Proposed change

Since UniFi Protect does not have an open API, an Early Access version of Protect can have a breaking change at any time causing the HA integration to break. The repair system can be used to have the user to acknowledge the risk of using EA versions.

Warning repair you get for running EA:
msedge_TgrBwKzAep

If you submit while still running EA, second warning:
msedge_r9Ts0xRERA

If an error occurs during startup while running EA, the above Repair will be deleted and replaced with:
msedge_PkSQ52hHfl

(note: Error: test is the str(Exception), I only had just did raise Exception("test") so that is why it is kind of bland.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 8, 2022

Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifiprotect can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign unifiprotect Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco
Copy link
Member

bdraco commented Nov 8, 2022

I think we could raise a different repair issue if the setup fails on ea

bdraco@ddf0628

@bdraco bdraco changed the title Add UniFi Protect repair to force user to confirm EA versions Improve awareness of issues using Early Access version of UniFi Protect with integration with detailed repairs Nov 8, 2022
@bdraco bdraco changed the title Improve awareness of issues using Early Access version of UniFi Protect with integration with detailed repairs Improve awareness of issues using Early Access versions of UniFi Protect with integration with detailed repairs Nov 8, 2022
@bdraco bdraco changed the title Improve awareness of issues using Early Access versions of UniFi Protect with integration with detailed repairs Improve awareness of issues using Early Access versions of UniFi Protect with detailed repairs Nov 8, 2022
@bdraco
Copy link
Member

bdraco commented Nov 8, 2022

I'm pretty comfortable with this now. I think its ready for tests

@AngellusMortis AngellusMortis changed the title Improve awareness of issues using Early Access versions of UniFi Protect with detailed repairs Detect Early Access versions of UniFi Protect and Warn User Nov 13, 2022
@AngellusMortis AngellusMortis marked this pull request as ready for review November 13, 2022 14:24
@bdraco
Copy link
Member

bdraco commented Nov 13, 2022

Still fighting with the cloud key to get it updated to EA

@bdraco
Copy link
Member

bdraco commented Nov 13, 2022

I've got the cloudkey factory reset now and running
UCK G2 Plus v3.0.12

I'm updating protect to 2.6.17 to test this

@bdraco
Copy link
Member

bdraco commented Nov 13, 2022

Looks like its working as expected.
Screenshot 2022-11-13 at 9 26 00 AM

Going to restart now to make sure it doesn't come back

@bdraco
Copy link
Member

bdraco commented Nov 13, 2022

Found an issue in testing but its not related to this change #82041

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing looks good 👍

@bdraco bdraco merged commit bfd2eb5 into home-assistant:dev Nov 13, 2022
@bdraco bdraco deleted the ufp-ea-block branch November 13, 2022 15:34
@bdraco
Copy link
Member

bdraco commented Nov 13, 2022

Thanks @AngellusMortis

@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants