Upgrade HomeWizard to platinum quality

[DCSBL]

Proposed change

I think this integration checks all (or at least most) the boxes to mark it as platinum.

Quality index

Below the list of requirements, checked if I think the requirement is met (and/or with comments)

No score​

• Satisfy all requirements for creating components and creating platforms.
• Configurable via configuration.yaml -> Not allowed for new integrations

Silver 🥈​

• Satisfying all No score level requirements.
• Connection/configuration is handled via a component.
• Set an appropriate SCAN_INTERVAL (if a polling integration)
• Raise PlatformNotReady if unable to connect during platform setup (if appropriate)
• Handles expiration of auth credentials. Refresh if possible or print correct error and fail setup. If based on a config entry, should trigger a new config entry flow to re-authorize. -> Will be added in Improve HomeWizard request issue reporting #82366
• Handles internet unavailable. Log a warning once when unavailable, log once when reconnected.
• Handles device/service unavailable. Log a warning once when unavailable, log once when reconnected.
• Operations like service calls and entity methods (e.g. Set HVAC Mode) have proper exception handling. Raise ValueError on invalid user input and raise HomeAssistantError for other failures such as a problem communicating with a device. → As of Implement state error handling in HomeWizard #84991
• Set available property to False if appropriate
• Entities have unique ID (if available)

Gold 🥇​

• Satisfying all Silver level requirements.
• Configurable via config entries.
• Don't allow configuring already configured device/service (example: no 2 entries for same hub)
• Discoverable (if available)
• Set unique ID in config flow (if available)
• Raise ConfigEntryNotReady if unable to connect during entry setup (if appropriate)
• Entities have device info (if available)
• Tests
• Full test coverage for the config flow
• Above average test coverage for all integration modules
• Tests for fetching data from the integration and controlling it
• Has a code owner
• Entities only subscribe to updates inside async_added_to_hass and unsubscribe inside async_will_remove_from_hass -> Not used
• Entities have correct device classes where appropriate
• Supports entities being disabled and leverages Entity.entity_registry_enabled_default to disable less popular entities
• If the device/service API can remove entities, the integration should make sure to clean up the entity and device registry. -> API cannot remove entities
• When communicating with a device or service, the integration implements the diagnostics platform which redacts sensitive information.

Platinum 🏆​

• Satisfying all Gold level requirements.
• Set appropriate PARALLEL_UPDATES constant -> Not quite sure about this one
• Support config entry unloading (called when config entry is removed)
• Integration + dependency are async
• Uses aiohttp or httpx and allows passing in websession (if making HTTP requests)
• Handles expired credentials (if appropriate) -> NA

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[Kane610]

As you're going from nothing to platinum I think it would be good to document what (and what Not) you're fulfilling on the quality scale

[DCSBL]

@Kane610 thanks for the suggestion, will work on that 👍

[DCSBL]

Main description has been updated with the list.

The line "From nothing to platinum".. is it more common that we take smaller steps? We can do that as well of course.

[Kane610]

Main description has been updated with the list.

The line "From nothing to platinum".. is it more common that we take smaller steps? We can do that as well of course.

There is no expected "going the line" procedure, but you should fulfil the different steps, so maybe expand what is needed for silver and put up a PR for that, etc.

[frenck]

For the silver level, this wasn't checked from the list:

Operations like service calls and entity methods (e.g. Set HVAC Mode) have proper exception handling. Raise ValueError on invalid user input and raise HomeAssistantError for other failures such as a problem communicating with a device. -> NA

Although it was set to be NA, that isn't correct. It does apply. Some example:

• The button entity (identify) could throw a connection error / could fail. However, this is not handled (and should be throwing an HomeAssistantError.
• The number entity, setting a value could fail in a similar way (and should also be throwing an HomeAssistantError in such cases, unless the value is unexpected, in that case a ValueError should be raised. Currently, these services have no error handling at all.
• Turning a switch entity on/off imposes similar issues as the above two mentioned ones.

[DCSBL]

Good catch, not considered. Should I change this in this PR or a separate to keep this one clean?

[frenck]

I would drop those in separate PR, and maybe mark this PR draft until it has been resolved.

[DCSBL]

Done! Let me know if you see any other potential issue

[frenck]

#84991 has been merged, I think we can move forward with this one now, right @DCSBL?

../Frenck

[DCSBL]

Yeah, thanks for the reminder!

[frenck]

LGTM, Thanks @DCSBL 👍

Congrats on the milestone! 🥇

../Frenck

[DCSBL]

Awesome! Thank you!