Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid custom device class from MinutPoint sound sensor #82934

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 29, 2022

Proposed change

This integration configured a device class sound_level on a sensor, but that is not a valid device class; It also isn't used for translations, thus should be removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (point) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of point can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign point Removes the current integration label and assignees on the issue, add the integration domain after the command.

@MartinHjelmare
Copy link
Member

Should we label this a breaking change?

@frenck
Copy link
Member Author

frenck commented Nov 29, 2022

I estimate the impact on this one is basically nihil, as almost no usage is registered for this integration. Combining that with actual use of iterating states in templates for the use of this device class, would be extremely unlikely.

@MartinHjelmare
Copy link
Member

Ok.

@MartinHjelmare MartinHjelmare merged commit d769359 into dev Nov 29, 2022
@MartinHjelmare MartinHjelmare deleted the frenck-2022-2143 branch November 29, 2022 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants