New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix manual.alarm_control_panel RestoreEntity bugs #82990
Conversation
26c6cb6
to
c41ec4b
Compare
Why did you rename all the functions to async_? There aren't actually any async calls in any of them |
Because they must be called from the event loop and therefore can/must call the async_ version of the functions. I followed what seemed to be the convention with async_track_point_in_time and async_render: they are not async themselves but are called async_. |
It helps if you split the refactor to a separate PR. |
Will do. |
1557fde
to
07d4e17
Compare
Instead of renaming the title of the PR to prefix "Draft: ", please just put the PR in actual draft. |
07d4e17
to
722ecd3
Compare
Sorry, got confused by GitHub/Gitlab differences. This is now draft until the dependency #83436 is ready and committed. |
This will be useful to properly restore timers on restart.
fce543d
to
534bf57
Compare
Tested with manual alarm control panel. If it is armed and HA is restarted it return in never ending pending state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me,
Thnx @bonzini!
Removed this from the milestone because it builds on top of the async conversion. |
Proposed change
The RestoreEntity implementation for the manual alarm control panel does not correctly restore timers. After this pull request, it restores the full state of the integration instead.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: