Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce unit enums for electric current and potential #83287

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Dec 5, 2022

Breaking change

FOR DEVELOPPERS ONLY: as of Home Assistant Core 2023.1, the following unit constants are deprecated and replaced
by a corresponding enum:

  • UnitOfElectricCurrent enumerator replaces ELECTRIC_CURRENT_*** constants
  • UnitOfElectricPotential enumerator replaces ELECTRIC_POTENTIAL_*** constants

Proposed change

Introduce unit enums for electric current and potential

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core new-feature small-pr PRs with less than 30 lines. labels Dec 5, 2022
@epenet epenet marked this pull request as draft December 5, 2022 11:09
@epenet epenet added the deprecation Indicates a breaking change to happen in the future label Dec 5, 2022
@epenet epenet marked this pull request as ready for review December 5, 2022 11:34
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@epenet epenet merged commit 7eda67b into home-assistant:dev Dec 5, 2022
@epenet epenet deleted the UnitOfElectricCurrent branch December 5, 2022 22:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core deprecation Indicates a breaking change to happen in the future new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants