Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass zwave_js config validation if driver not ready #83410

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Dec 6, 2022

Breaking change

Proposed change

  • Do not do dynamic validation of automation if driver is not ready.
  • This is a suboptimal fix to not error in the config validation stage and allow the automation integration to be setup. Attaching eg a trigger when the driver is not ready will still fail. In that case the particular automation will fail to setup.
  • A better fix would be to not finish config entry setup until the driver is ready, but that will require some more time and thought.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 6, 2022

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the issue, add the integration domain after the command.

@MartinHjelmare MartinHjelmare added this to the 2022.12.0 milestone Dec 6, 2022
@balloob balloob merged commit 874315c into dev Dec 6, 2022
@balloob balloob deleted the fix-zwave-js-driver-not-ready-validation branch December 6, 2022 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zwave_js causes automation setup fail --> ValueError("Driver is not ready.")
3 participants