Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve local calendar input validation error handling #83563

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

allenporter
Copy link
Contributor

Proposed change

Improve local calendar input validation error handling by re-throwing pydantic input validation errors as voluptuous validation errors handled by home assistant. Also adds logging with the contents of the request.

I am not currently aware of how to reproduce this given the input validation in #83413 stops the known validation errors. However, when manually testing I reverted that PR and verified that the error is handled identically. (However, leaving the validation there in the websocket lets it handle to other calendar integrations like google calendar too).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter added this to the 2022.12.1 milestone Dec 8, 2022
@balloob balloob merged commit 16f94e6 into home-assistant:dev Dec 8, 2022
@balloob balloob mentioned this pull request Dec 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants