Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blebox discovery/zeroconf #83837

Merged
merged 13 commits into from
Dec 23, 2022
Merged

Add blebox discovery/zeroconf #83837

merged 13 commits into from
Dec 23, 2022

Conversation

riokuu
Copy link
Contributor

@riokuu riokuu commented Dec 12, 2022

Proposed change

Devices are proagating info over mDNS.
PR introduces zeroconf/mDNS as a integration ConfigFlow.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bbx-a, mind taking a look at this pull request as it has been labeled with an integration (blebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of blebox can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign blebox Removes the current integration label and assignees on the issue, add the integration domain after the command.

@riokuu
Copy link
Contributor Author

riokuu commented Dec 12, 2022

Translations make the volume of this PR.

@riokuu riokuu requested a review from bdraco December 13, 2022 12:20
@riokuu
Copy link
Contributor Author

riokuu commented Dec 19, 2022

Hey @bdraco any further actions required to accept this pr? BR

@bdraco
Copy link
Member

bdraco commented Dec 19, 2022

Hey @bdraco any further actions required to accept this pr? BR

Its just waiting for me or someone else to have time to review it

@bdraco bdraco self-requested a review December 19, 2022 22:37
@riokuu
Copy link
Contributor Author

riokuu commented Dec 20, 2022

I'm not the one to tell :)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 21, 2022
@riokuu
Copy link
Contributor Author

riokuu commented Dec 22, 2022

Looks like codecov/patch is failing not over my code. How to skip this or make work?

@emontnemery
Copy link
Contributor

@riokuu codecov is not 100% accurate, failing codecov tests does not block merging 👍

@bdraco
Copy link
Member

bdraco commented Dec 23, 2022

LGTM. One small comment above

riokuu and others added 2 commits December 23, 2022 08:48
@riokuu riokuu requested a review from bdraco December 23, 2022 11:51
@bdraco
Copy link
Member

bdraco commented Dec 23, 2022

Thanks @riokuu

@bdraco bdraco merged commit c737378 into home-assistant:dev Dec 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants