-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Huawei LTE to use Entity Description #83904
Conversation
Hey there @scop, @fphammerle, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Thought many times I'd do this, but never got around to it. Thanks! Implementationwise looks good on surface, I'll take a closer look a bit later when I find time unless someone beats me to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM still, just one suggestion added, pre-approved with that 👍
Slightly annoying having to repeat the descriptions
dict key and the entity description key, but I think we can live with that and at least it keeps things simple.
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
* Refactor Huawei LTE to use Entity Description * Apply suggestions from code review Co-authored-by: Ville Skyttä <ville.skytta@iki.fi> Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
Proposed change
Refactor Huawei LTE to use Entity Description
Also add DURATION, FREQUENCY and DATA_SIZE device classes
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: