Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip client metadata values that are None #84293

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Dec 20, 2022

Proposed change

In some cases, the location info can return with None for these keys, if that is the case we should not send them, as that will fail.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign cloud Removes the current integration label and assignees on the issue, add the integration domain after the command.

@ludeeus ludeeus marked this pull request as ready for review December 20, 2022 14:28
@balloob balloob merged commit 63807e4 into dev Dec 20, 2022
@balloob balloob deleted the no-none-client-metadata branch December 20, 2022 14:32
@frenck
Copy link
Member

frenck commented Dec 20, 2022

Should this be tagged on the milestone @balloob / @ludeeus ?

@balloob balloob added this to the 2022.12.8 milestone Dec 20, 2022
@balloob
Copy link
Member

balloob commented Dec 20, 2022

Yeah let's do that.

@balloob balloob mentioned this pull request Dec 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start Home Assistant Cloud trial
3 participants