Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Tibber rt Pulse streaming #84313

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Improve Tibber rt Pulse streaming #84313

merged 1 commit into from
Dec 21, 2022

Conversation

Danielhiversen
Copy link
Member

Signed-off-by: Daniel Hjelseth Høyer github@dahoiv.net

Breaking change

Proposed change

Update Tibber library Danielhiversen/pyTibber@0.26.5...0.26.6
Try to fix the issues mentioned here:
#84265 (comment)
#84179 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Danielhiversen
Improve rt Pulse streaming
2046484 
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@Danielhiversen Danielhiversen added this to the 2022.12.8 milestone Dec 20, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 20, 2022
@MartinHjelmare MartinHjelmare changed the title Improve rt Pulse streaming Improve Tibber rt Pulse streaming Dec 21, 2022
MartinHjelmare
MartinHjelmare approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 61e13bf into dev Dec 21, 2022
@MartinHjelmare MartinHjelmare deleted the tibber_0266 branch December 21, 2022 04:59
balloob pushed a commit that referenced this pull request Dec 21, 2022
@Danielhiversen @balloob
Improve Tibber rt Pulse streaming (#84313)
7f0a9a5 
Improve rt Pulse streaming

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@balloob balloob mentioned this pull request Dec 21, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency dependency-bump integration: tibber Quality Scale: silver small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2022.12.8
Development

Successfully merging this pull request may close these issues.
4 participants
@Danielhiversen @MartinHjelmare @frenck @balloob