New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more diagnostic sensors to iRobot #84995
Conversation
Hi Xitee1 It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hey there @pschmitt, @cyr-ius, @shenxn, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your first contribution! I have some suggestions for you.
Btw, you still need to sign the CLA as mentioned in the comment above. |
I already have signed CLA. The bot has even added the "cla-signed" label to the PR. |
So you have! I must have missed that 🤦 |
Is there anything wrong with this? This PR is open for months now and still hasn't been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Seems to me like a good extension of the existing roomba integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I checked it in my IDE and manually edited it in the Github web editor because for some reason almost all checks fail after merging dev into irobot_more_sensors. I have resolved the conflicts and comitted but for some reason Github still says there are conflicts. And I can't resolve it in the Github conflicts web editor because apparently it is too much for the merge web editor even thought it is a single line of code. I'm giving up at this now.. such an easy and simple addition and so much stress and time consuming getting that PR trough. |
I'm going to close this PR since you've indicated you don't want to continue this. Feel free to reopen or make a new one if you change your mind later. Thanks for willing to contribute 👍 |
4b58dad
to
aa9f719
Compare
Co-authored-by: 930913 <3722064+930913@users.noreply.github.com>
Co-authored-by: Xitee <59659167+Xitee1@users.noreply.github.com>
Untested.
aa9f719
to
dea5053
Compare
@frenck Done. |
Also tested and looks okay |
Breaking change
Proposed change
The iRobot integration currently unlike the official iRobot-App does not show much information's/statistics about the robot like the total missions and total cleaning time. I've found out that the information's are already available and there just are no sensors for it.
So I have added the following sensors:
The following attributes to the vacuum entity have been added too:
I hope that I did everything correctly. This is my first PR :)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: