Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for more roomba sensors #25509

Merged
merged 2 commits into from
Oct 22, 2023

Conversation

Xitee1
Copy link
Contributor

@Xitee1 Xitee1 commented Jan 2, 2023

Proposed change

Add the additional roomba sensors that I have added in my other PR for HA core.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Jan 2, 2023
@home-assistant home-assistant bot added the has-parent This PR has a parent PR in a other repo label Jan 2, 2023
@home-assistant
Copy link

home-assistant bot commented Jan 2, 2023

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 2, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR depends on a change in the Core codebase and thus depends on a next release of Home Assistant. This PR is therefore, currently targeting an incorrect branch. It is targeting current but should be targeting the next branch.

Please change the target branch of this PR to the next branch and git rebase your changes on the next branch to clean up unrelated commits.

Thanks 👍

../Frenck

@Xitee1 Xitee1 changed the base branch from current to next January 3, 2023 17:34
@home-assistant home-assistant bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 3, 2023
@home-assistant home-assistant bot added the next This PR goes into the next branch label Jan 3, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jan 5, 2023
@bdraco
Copy link
Member

bdraco commented Apr 19, 2023

Closing this PR as the parent has been closed

home-assistant/core#84995

@bdraco bdraco closed this Apr 19, 2023
@home-assistant home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label Apr 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
@gjohansson-ST gjohansson-ST reopened this May 25, 2023
@gjohansson-ST gjohansson-ST added the awaits-parent Awaits the merge of an parent PR label May 25, 2023
@Quentame Quentame removed their request for review October 19, 2023 16:17
@frenck frenck added the parent-merged The parent PR has been merged already label Oct 22, 2023
@frenck frenck merged commit 62672ff into home-assistant:next Oct 22, 2023
2 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Oct 22, 2023
@Xitee1 Xitee1 deleted the irobot_more_sensors branch October 22, 2023 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants