Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reauth config flow to honeywell #86170

Merged
merged 10 commits into from
Jan 30, 2023

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 18, 2023

Proposed change

Type of change

Add reauth config flow to Honeywell integration

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration (honeywell) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of honeywell can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign honeywell Removes the current integration label and assignees on the issue, add the integration domain after the command.

@rdfurman
Copy link
Contributor

rdfurman commented Jan 18, 2023

Not sure I fully understand what is being implemented here. Is this going to make HASS request the user enter their password again when an authentication error happens for a honeywell integration that has already been added?

The PR description could use a little more detail IMO. It would go a long way with helping me understand what you're adding here. I usually show a screenshot of what the config window now looks like when making changes to the config flow as well.

@mkmer
Copy link
Contributor Author

mkmer commented Jan 18, 2023

@rdfurman : Yes, it adds the "standard" config flow for re-authorization when the API reports a password error when the platform attempts to initialize. I'm surprised it made it in without it. (It was required on one of my first integrations). Without this flow, the user MUST remove the integration to change the password.

@rdfurman
Copy link
Contributor

LGTM now that it has 100% coverage.

@mkmer
Copy link
Contributor Author

mkmer commented Jan 18, 2023

Yah - the coverage problem wasn't in our code, something in another integration slid into the dev branch.

Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but i've not done any reauth flows.

@mkmer
Copy link
Contributor Author

mkmer commented Jan 26, 2023

Do we get a merge?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 7368c86 into home-assistant:dev Jan 30, 2023
@mkmer mkmer deleted the Honeywell-ReauthFlow branch January 30, 2023 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
@balloob balloob added this to the 2023.2.1 milestone Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants