Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Honeywell unavailable state on connection lost #86312

Merged
merged 6 commits into from
Jan 21, 2023

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 20, 2023

Proposed change

Set _attr_unavailable when service is not connected

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration (honeywell) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of honeywell can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign honeywell Removes the current integration label and assignees on the issue, add the integration domain after the command.

@mkmer mkmer changed the title Honeywell fix for issue #62957 Fix for issue #62957 in Honeywell Jan 20, 2023
@MartinHjelmare MartinHjelmare changed the title Fix for issue #62957 in Honeywell Fix Honeywell unavailable state on connection lost Jan 20, 2023
@mkmer
Copy link
Contributor Author

mkmer commented Jan 21, 2023

I feel like this is now a better solution.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CI failure is unrelated. I'll go ahead and merge here.

@MartinHjelmare
Copy link
Member

Side note: A follow up PR that adds raising ConfigEntryAuthFailed during config entry setup if credentials are bad, and a reauth flow in the config flow, would be good.

@MartinHjelmare MartinHjelmare merged commit 5306883 into home-assistant:dev Jan 21, 2023
@mkmer
Copy link
Contributor Author

mkmer commented Jan 21, 2023

The PR has been in and waiting :)
#86170

@mkmer mkmer deleted the Fix-issue-62957 branch January 21, 2023 22:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honeywell TCC (US) Internet Connection Lost - Status Reporting
2 participants