Add tests to Honeywell #86392
Closed
Add tests to Honeywell #86392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: honeywell
small-pr
|
Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
kirill578
approved these changes
Jan 25, 2023
mkmer
force-pushed
the
Add-climate-tests
branch
5 times, most recently
from
6e161a7
to
d2624a7
Compare
mkmer
force-pushed
the
Add-climate-tests
branch
from
aaa12c0
to
042def8
Compare
Z-Wave.Me integration Description improved
…ome-assistant#87096) Skipping entities that are hidden or have entity category
…nt#87090) Co-authored-by: Franck Nijhof <git@frenck.dev>
…7013) * Add is_numeric property to Sensor class * Follw up comment * Update homeassistant/components/sensor/__init__.py Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> * Update homeassistant/components/sensor/__init__.py Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> * Tests and corrections * Simplify converion check * Correct custom device class handling * Update homeassistant/components/sensor/__init__.py Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> * rename to numeric_state_expected * Replace with new const * Adjust docstr * Update homeassistant/components/sensor/__init__.py Co-authored-by: Franck Nijhof <frenck@frenck.nl> * Move to const * Correct logic * Do not use bool * Adjust docstr must be numeric * remote state from docstr * protect numeric_state_expected * Use try_parse_enum for custom class check * Remove redundant type hints --------- Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Fixes ``` recorder/test_init.py:251: SAWarning: SELECT statement has a cartesian product between FROM element(s) "states" and FROM element "state_attributes". Apply join condition(s) between each element to resolve. ```
* Add missing PowerConverter to UNIT_CONVERTERS * Adjust tests
thecode
removed request for
rytilahti,
pavoni,
andrey-git,
bramkragten,
Adminiuga,
ochlocracy,
allenporter,
janiversen,
Swamp-Ig,
marcelveldt,
andrewsayre,
kellerza,
epenet,
OttoWinter,
jbouwh,
teharris1,
farmio,
emontnemery,
Quentame,
ludeeus,
davet2001,
Ernst79,
Kane610,
puddly,
mib1185 and
chemelli74
|
Rebase screwup :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add missing climate tests for 100% coverage.
Update test_init.py 100% coverage.
Remove unreachable code from climate.py.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: