Add tests to honeywell #87209
Merged
Add tests to honeywell #87209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: honeywell
small-pr
|
Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
mkmer
force-pushed
the
Climate_tests_honeywell
branch
from
a085ade
to
c7a5131
Compare
frenck
added
the
smash
epenet
reviewed
Mar 20, 2023
emontnemery
reviewed
Mar 30, 2023
Cleanup related to comments for EM
|
I'm not sure why the snapshot test is failing in CI when it passes locally.... |
Please rebase on latest dev. |
emontnemery
requested changes
Apr 3, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
emontnemery
approved these changes
Apr 12, 2023
tkhadimullin
pushed a commit
to tkhadimullin/ha-core
that referenced
this pull request
Apr 13, 2023
* lower case aiosomecomfort * add tests * Test updates for 0.0.6 * lower case aiosomecomfort * Missing changes after merge * Add missing type hints * Fix tests for PR#89393 * Test hold on when setting temperature * Remove unnecessary init function * Remove unnecessary assert * Address missing tests Cleanup related to comments for EM * Move to snapshot for static test * Updated snapshot * Remove unnecessary assert
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add tests to reach 100% coverage to Honeywell - Platinum Status reached?
Remove try/except in .system_mode no longer raised by API.
Reissue of PR #86392 due to rebase problem.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: