Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reauthentication support for LIVISI integration #86717

Conversation

StefanIacobLivisi
Copy link
Contributor

@StefanIacobLivisi StefanIacobLivisi commented Jan 26, 2023

Breaking change

Proposed change

Add reauthentication support in LIVISI integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

aiolivisi: https://github.com/StefanIacobLivisi/aiolivisi

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@StefanIacobLivisi StefanIacobLivisi changed the title Add reauthentication support Add reauthentication support for LIVISI integration Jan 26, 2023
@epenet epenet marked this pull request as draft January 26, 2023 15:03
@epenet
Copy link
Contributor

epenet commented Jan 26, 2023

Draft until #86721 is merged

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure 100% coverage on the config flow.

@StefanIacobLivisi
Copy link
Contributor Author

Hello @epenet , I have an error when I try to commit my changes:

usage: pylint [options]
pylint: error: Unrecognized option found: ignore-missing-annotations=y

Did you see this message before?

@epenet
Copy link
Contributor

epenet commented Feb 16, 2023

No I have not seen this. It looks like something is wrong on your development environment.
Maybe it is an python 3.9 versus python 3.10 issue... we dropped support for python 3.9 recently so you may need to rebuild your environment.

@StefanIacobLivisi
Copy link
Contributor Author

Thank you for your suggestion. I rebuilt my environment and now the problem is solved.

@StefanIacobLivisi
Copy link
Contributor Author

The code coverage for the config_flow.py is now 100%.

@StefanIacobLivisi StefanIacobLivisi marked this pull request as ready for review February 17, 2023 16:46
@StefanIacobLivisi
Copy link
Contributor Author

@epenet can you please take a look again at this pull request?

homeassistant/components/livisi/translations/en.json Outdated Show resolved Hide resolved
homeassistant/components/livisi/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/livisi/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/livisi/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/livisi/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/livisi/config_flow.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 27, 2023 08:41
@StefanIacobLivisi StefanIacobLivisi marked this pull request as ready for review February 27, 2023 14:49
@home-assistant home-assistant bot requested a review from epenet February 27, 2023 14:50
homeassistant/components/livisi/const.py Outdated Show resolved Hide resolved
homeassistant/components/livisi/config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft February 28, 2023 10:09
@home-assistant home-assistant bot marked this pull request as draft March 17, 2023 13:42
@home-assistant
Copy link

Hi @StefanIacob29

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Tobster77
Copy link

For me, the issue still appears:
I updated HA to the most recent version 2023.4.2 (HASS on Pi3). Plays nicely for one day or two, then the SHC and all of its devices get unavailable. User experience is just like StefanIacobLivisi/aiolivisi#4.

I reported the issue StefanIacobLivisi/aiolivisi#11.

@Tobster77
Copy link

Tobster77 commented May 12, 2023

Any chance that this CLA thing gets resolved? I have no idea on its meaning, but can I (as a normal user) somehow support? @epenet: Can you give a quick remark? Thanks.

@home-assistant
Copy link

Hi @StefanIacob29

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@epenet
Copy link
Contributor

epenet commented May 12, 2023

Any chance that this CLA thing gets resolved? I have no idea on its meaning, but can I (as a normal user) somehow support? @epenet: Can you give a quick remark? Thanks.

CLA issue has to be resolved by the PR authors.

@Tobster77
Copy link

Tobster77 commented Jun 5, 2023

It is so sad that the fix is there, but @StefanIacobLivisi, @StefanIacob29 does not find the time to sign the CLA since weeks. Please, we need a working solution here. Otherwise, the binding is useless as it looses connection after two days...

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 3, 2023
@github-actions github-actions bot closed this Sep 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants