Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check return and mqtt fixtures typing in tests #87607

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Feb 7, 2023

Proposed change

Check return type and mqtt fixtures typing in tests

Linked to #87527
cc @jbouwh

Example:

# pylint --disable=all --enable=hass-argument-type,hass-return-type --ignore-missing-annotations=n tests/components/axis/test_device.py
************* Module tests.components.axis.test_device
tests/components/axis/test_device.py:80:35: W7431: Argument hass should be of type ['HomeAssistant', 'HomeAssistant | None'] in test_device_support_mqtt (hass-argument-type)
tests/components/axis/test_device.py:80:0: W7432: Return type should be None in test_device_support_mqtt (hass-return-type)
tests/components/axis/test_device.py:80:41: W7431: Argument mqtt_mock should be of type MqttMockHAClient in test_device_support_mqtt (hass-argument-type)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Feb 7, 2023
@epenet epenet changed the title Check return type and mqtt fixtures typing in tests Check return and mqtt fixtures typing in tests Feb 7, 2023
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this will help a lot.
Looks good to me,
Thnx @epenet !

@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Feb 7, 2023
@epenet epenet merged commit ea32a2a into home-assistant:dev Feb 7, 2023
@epenet epenet deleted the test-functions branch February 7, 2023 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants