-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HomeKit Controller Thread Provisioning #87809
Conversation
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
21112f7
to
e20b7dd
Compare
So the plan at the moment is to land this with the button entity. The button entity is pretty solid, my flakiest device just successfully provisioned from BLE to Thread 10 times in a row without any failures. In parallel, work on the HA panel teased in https://www.home-assistant.io/blog/2023/02/08/state-of-matter-and-thread/#thread is happening. When that work is done, we should be able to remove the button entity and integrate into the thread panel instead. Now the new aiohomekit tag is out, we just need to add some tests. I'm hoping they'll be ready tomorrow. |
e20b7dd
to
9ef6f40
Compare
Do we need any docs for this? |
I'm definitely going to add something, but I need to see where we get with the thread panel. I was thinking if it looks like we aren't going to make it, i'll add some for this. Otherwise i'll add them for whatever the thread panel ends up looking like. |
68063b1
to
e0c7ae2
Compare
Rebased to pick up otbr test fixes |
Proposed change
Support provisioning compatible HomeKit devices onto the preferred Thread network.
aiohomekit changes: Jc2k/aiohomekit@2.5.0...2.6.1
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: