Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HomeKit Controller Thread Provisioning #87809

Merged
merged 18 commits into from
Feb 15, 2023

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Feb 9, 2023

Proposed change

Support provisioning compatible HomeKit devices onto the preferred Thread network.

aiohomekit changes: Jc2k/aiohomekit@2.5.0...2.6.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Feb 9, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit_controller can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign homekit_controller Removes the current integration label and assignees on the issue, add the integration domain after the command.

@Jc2k
Copy link
Member Author

Jc2k commented Feb 14, 2023

So the plan at the moment is to land this with the button entity. The button entity is pretty solid, my flakiest device just successfully provisioned from BLE to Thread 10 times in a row without any failures.

In parallel, work on the HA panel teased in https://www.home-assistant.io/blog/2023/02/08/state-of-matter-and-thread/#thread is happening. When that work is done, we should be able to remove the button entity and integrate into the thread panel instead.

Now the new aiohomekit tag is out, we just need to add some tests. I'm hoping they'll be ready tomorrow.

@Jc2k Jc2k marked this pull request as ready for review February 15, 2023 14:09
@Jc2k Jc2k requested a review from bdraco as a code owner February 15, 2023 14:09
@bdraco
Copy link
Member

bdraco commented Feb 15, 2023

Do we need any docs for this?

@Jc2k
Copy link
Member Author

Jc2k commented Feb 15, 2023

I'm definitely going to add something, but I need to see where we get with the thread panel. I was thinking if it looks like we aren't going to make it, i'll add some for this. Otherwise i'll add them for whatever the thread panel ends up looking like.

@Jc2k
Copy link
Member Author

Jc2k commented Feb 15, 2023

Rebased to pick up otbr test fixes

@Jc2k Jc2k merged commit f5a05c1 into home-assistant:dev Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants