Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kegtron state class for volume sensors #87950

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Conversation

Ernst79
Copy link
Contributor

@Ernst79 Ernst79 commented Feb 12, 2023

Proposed change

Fix for the following error, as reported in #87888

Etity sensor.kegtron_kt_200_93f5_volume_start_port_2 (<class 'homeassistant.components.kegtron.sensor.KegtronBluetoothSensorEntity'>) is using state class 'measurement' which is impossible considering device class ('volume') it is using; expected None or one of 'total_increasing', 'total'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+kegtron%22

I think the default state class None is ok for the the volume_start and keg_size sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Ernst79 Ernst79 marked this pull request as ready for review February 12, 2023 19:59
@frenck frenck merged commit 18d3e4d into home-assistant:dev Feb 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2023
@Ernst79 Ernst79 deleted the kegtron branch January 20, 2024 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kegtron State Class Issue
3 participants