Calculate _attr_native_value when no restore state and appliance is running in Whirlpool #88559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: whirlpool
small-pr
|
Hey there @abmantis, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
move init at startup if _attr_native_value is None
emontnemery
previously requested changes
Feb 22, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
mkmer
changed the title
mkmer
changed the title
|
I believe the requested changes have been satisfied. What do I need to do to get this over the bar? |
frenck
added
the
smash
|
Stuck? |
balloob
approved these changes
May 31, 2023
| if ( | ||
| isinstance(self._attr_native_value, datetime) | ||
| and abs(new_timestamp - self._attr_native_value) > timedelta(seconds=60) | ||
| or self._attr_native_value is None |
There was a problem hiding this comment.
It's more efficient to start with the None check as that is faster than isinstance and Python conditions will short circuit.
| await init_integration(hass) | ||
| # restore from cache | ||
| state = hass.states.get(entity_id) | ||
| state.state = "unknown" |
There was a problem hiding this comment.
Should this be an assertion?
| state.state = "unknown" | ||
|
|
||
| state = await update_sensor_state(hass, entity_id, mock_sensor1_api) | ||
| state.state = datetime.now().isoformat() |
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently, if the appliance is running when the integration is added (aka restore state is None), the time stamp will not be calculated until the appliance finishes a cycle.
This change will allow a time stamp to be set if the appliance is running when the integration is added.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: