-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate _attr_native_value when no restore state and appliance is running in Whirlpool #88559
Merged
balloob
merged 10 commits into
home-assistant:dev
from
mkmer:Whirlpool-Init-when-running
May 31, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
98ee0a8
Initialize _attr_native_value when running
mkmer aec6af4
Fix return type on update_sensor_state()
mkmer 0144d14
allow update _attr_native_value when running and none
mkmer 4e7f44c
Merge branch 'dev' into Whirlpool-Init-when-running
mkmer 24e1729
Merge branch 'dev' into Whirlpool-Init-when-running
mkmer d50e581
Merge branch 'dev' into Whirlpool-Init-when-running
mkmer 18fe139
Merge branch 'dev' into Whirlpool-Init-when-running
mkmer ee45e67
Merge branch 'dev' into Whirlpool-Init-when-running
mkmer 451dd6d
Merge branch 'dev' into Whirlpool-Init-when-running
mkmer db60869
Merge branch 'dev' into Whirlpool-Init-when-running
mkmer File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ async def update_sensor_state( | |
hass: HomeAssistant, | ||
entity_id: str, | ||
mock_sensor_api_instance: MagicMock, | ||
) -> None: | ||
) -> State: | ||
"""Simulate an update trigger from the API.""" | ||
|
||
for call in mock_sensor_api_instance.register_attr_callback.call_args_list: | ||
|
@@ -300,6 +300,23 @@ async def test_restore_state( | |
assert state.state == thetimestamp.isoformat() | ||
|
||
|
||
async def test_no_restore_state( | ||
hass: HomeAssistant, | ||
mock_sensor_api_instances: MagicMock, | ||
mock_sensor1_api: MagicMock, | ||
) -> None: | ||
"""Test sensor restore state with no restore.""" | ||
# create and add entry | ||
entity_id = "sensor.washer_end_time" | ||
await init_integration(hass) | ||
# restore from cache | ||
state = hass.states.get(entity_id) | ||
state.state = "unknown" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be an assertion? |
||
|
||
state = await update_sensor_state(hass, entity_id, mock_sensor1_api) | ||
state.state = datetime.now().isoformat() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This too? |
||
|
||
|
||
async def test_callback( | ||
hass: HomeAssistant, | ||
mock_sensor_api_instances: MagicMock, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more efficient to start with the
None
check as that is faster thanisinstance
and Python conditions will short circuit.