-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZHA network settings API #88564
Merged
Merged
ZHA network settings API #88564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
puddly
force-pushed
the
puddly/zha-api
branch
from
February 22, 2023 22:39
a1be752
to
bccfaf5
Compare
puddly
force-pushed
the
puddly/zha-api
branch
2 times, most recently
from
March 14, 2023 13:19
a43c4ad
to
0c51cb8
Compare
emontnemery
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
ZHA has a websocket API to read network settings from a running coordinator, but it does not have an API to read network settings with Python alone. This PR implements the latter and includes a way to read network settings with a fallback to reading them from
zigbee.db
.This PR appears large only because I renamed
zha/api.py
tozha/websocket_api.py
.The main addition is
async_get_network_settings
: if there is an active network, those settings are used. Otherwise, if ZHA is inactive but there is still ZHA state in the/config/
folder, the database is used. Otherwise,None
is returned.async_get_radio_type
andasync_get_radio_path
are also added to provide a public API to read this information from the ZHA config entry.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: