Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate iaqualink httpx client upon service exception #89341

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

flz
Copy link
Contributor

@flz flz commented Mar 8, 2023

Breaking change

Proposed change

Every hour, the iaqualink backend closes the http connection. Somehow, the httpx client doesn't restart the http connection so the best way we have to deal with the issue is to re-create the httpx client instance. That's being done here by force-closing the client via a library call.

Also, catch httpx Exceptions in await_and_reraise() which was forgotten in the previous fix.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@flz
Copy link
Contributor Author

flz commented Mar 8, 2023

Please merge to 2023.03 if/when approved!

@MartinHjelmare MartinHjelmare changed the title Recreate httpx client upon service exception Recreate iaqualink httpx client upon service exception Mar 8, 2023
@epenet epenet added this to the 2023.3.2 milestone Mar 8, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @flz 👍

../Frenck

@frenck frenck merged commit 2ec78ae into home-assistant:dev Mar 8, 2023
@frenck frenck mentioned this pull request Mar 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
@flz flz deleted the recreate-client branch March 11, 2023 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest fix to IAquakink (2023.2.4) has not resolved issue
3 participants