Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dual lens cameras in Reolink #89554

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

starkillerOG
Copy link
Contributor

Breaking change

Proposed change

Support dual lens reolink cameras by adding streams for the second lens.
The following models are dual lens cameras:

  • Reolink Duo PoE
  • Reolink Duo WiFi
  • Reolink Duo 2 PoE
  • Reolink Duo 2 WiFi
  • Reolink Duo Floodlight PoE
  • Reolink Duo Floodlight WiFi
  • Reolink TrackMix PoE
  • Reolink TrackMix WiFi

Bump reolink aio to 0.5.4:
starkillerOG/reolink_aio@0.5.3...0.5.4

  • Add stream information for dual lens cameras
  • Prevent incorrect warning about zoom capability

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG
Copy link
Contributor Author

Test failure is unrelated: FAILED tests/components/flux_led/test_init.py::test_time_sync_startup_and_next_day - AssertionError: assert 1 == 2

@epenet epenet changed the title Reolink support dual lens cameras Add support for dual lens cameras in Reolink Mar 13, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck merged commit 431a8d0 into home-assistant:dev Mar 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants