Fix EntityComponent lingering timer in helper tests #89801
Conversation
| @@ -46,6 +46,7 @@ async def test_polling_only_updates_entities_it_should_poll( | |||
| ) -> None: | |||
| """Test the polling of only updated entities.""" | |||
| component = EntityComponent(_LOGGER, DOMAIN, hass, timedelta(seconds=20)) | |||
| await component.async_setup({}) | |||
There was a problem hiding this comment.
This is the first type of change in the file.
Tests that create an instance of EntityComponent need to call async_setup so that it starts listening for STOP event from home assistant, which will trigger an automatic cleanup.
| @@ -598,6 +615,8 @@ async def test_registry_respect_entity_namespace( | |||
| await platform.async_add_entities([entity]) | |||
| assert entity.entity_id == "test_domain.ns_device_name" | |||
|
|
|||
| await platform.async_shutdown() | |||
There was a problem hiding this comment.
This is the second type of change in the file.
Tests that create an instance of MockEntityPlatform need to shut it down at the end of the test to enforce a cleanup.
There was a problem hiding this comment.
Can we have a MockEntityPlatform register itself to shut down itself at the end of a test?
There was a problem hiding this comment.
I have removed these changes for now.
I'll have another look at this one later.
There was a problem hiding this comment.
I think I found a solution for this.
In order to avoid holding up this PR, I created a separate one in #89849
epenet
changed the title
epenet
changed the title
Proposed change
Linked to #89292
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: