Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sensor type hints in integrations #90031

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Improve sensor type hints in integrations #90031

merged 2 commits into from
Mar 21, 2023

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Mar 21, 2023

Proposed change

Linked to #90024

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet epenet requested a review from bdraco as a code owner March 21, 2023 09:38
@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Mar 21, 2023
@epenet epenet mentioned this pull request Mar 21, 2023
Merged
39 tasks
@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Mar 21, 2023
StevenLooman
StevenLooman approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@StevenLooman StevenLooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For future reviews (for me), should we try to minimize the use of Any?

@epenet
Copy link
Contributor Author

epenet commented Mar 21, 2023

LGTM. For future reviews (for me), should we try to minimize the use of Any?

Yes.
Any has it's uses, but it should indeed be avoided if a more precise type is know and available.

@epenet epenet merged commit 0e1c76f into home-assistant:dev Mar 21, 2023
@epenet epenet deleted the sensor branch March 21, 2023 10:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StevenLooman StevenLooman StevenLooman approved these changes

@emontnemery emontnemery emontnemery approved these changes

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees
No one assigned
Labels
cla-signed code-quality small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epenet @StevenLooman @emontnemery