Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zwave-me-ws version to 0.3.6 #90233

Merged
merged 7 commits into from
Mar 28, 2023

Conversation

lawfulchaos
Copy link
Contributor

@lawfulchaos lawfulchaos commented Mar 24, 2023

Breaking change

Proposed change

Update zwave-me-ws to version 0.3.6

Add deletion event support
Fix value formats

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Z-Wave-Me, @PoltoS, mind taking a look at this pull request as it has been labeled with an integration (zwave_me) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_me can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_me Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@lawfulchaos lawfulchaos changed the title Update zwave-me-ws version to 0.3.3 Update zwave-me-ws version to 0.3.6 Mar 24, 2023

@callback
def get_new_data(self, new_data):
def get_new_data(self, new_data: ZWaveMeData):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial typed, missing return type.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I clicked the wrong button, I meant to leave a request for change.

@home-assistant home-assistant bot marked this pull request as draft March 26, 2023 09:51
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@lawfulchaos lawfulchaos marked this pull request as ready for review March 28, 2023 14:28
@home-assistant home-assistant bot requested a review from frenck March 28, 2023 14:28
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lawfulchaos 👍

../Frenck

@frenck frenck merged commit 4b3c1f2 into home-assistant:dev Mar 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants