Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goodwe export limit unit on single phase DT inverters #90427

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

mletenay
Copy link
Contributor

Proposed change

Single phase inverters of DT protocol family (D-NS, XS) use Watts as grid export limit value
(in contrast to % of nominal power for 3 phase inverters).
This fix corrects the improper behavior of using always % and actually forcing limit to be just 100 Watts.
Code was fixed both in HA number descriptor detection and also
in the underlying library https://github.com/marcelblijleven/goodwe/releases/tag/v0.2.29

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (goodwe) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of goodwe can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign goodwe Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 28, 2023
@MartinHjelmare MartinHjelmare changed the title Fix export limit unit on single phase DT inverters Fix goodwe export limit unit on single phase DT inverters Mar 29, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

homeassistant/components/goodwe/number.py Outdated Show resolved Hide resolved
@emontnemery emontnemery merged commit a1c9491 into home-assistant:dev Mar 29, 2023
@mletenay mletenay deleted the goodwe_89859 branch March 29, 2023 21:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cla-signed integration: goodwe Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoodWe inverter Power limit value at 100W after restart of HA
3 participants