-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voip integration #90945
Voip integration #90945
Conversation
Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b25cf0b
to
7ddef47
Compare
1b686b5
to
8c2da3a
Compare
02589a1
to
8cb74a8
Compare
_LOGGER = logging.getLogger(__name__) | ||
_IP_WILDCARD = "0.0.0.0" | ||
|
||
__all__ = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only needed if another integration will import names from this integration. I don't think that's the case here. We can remove it.
asyncio.DatagramProtocol, | ||
], | ||
) -> asyncio.DatagramTransport: | ||
transport, _protocol = await hass.loop.create_datagram_endpoint( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like something that should be done in a 3rd party library.
Abstract the asyncio datagram protocol interface so the library user doesn't need to know about that detail.
Breaking change
Proposed change
Add voice over IP (VoIP) integration for use with phones connected to a Grandstream (HT801/HT802).
Runs pipeline for configured language in a loop, taking in STT commands and responding with TTS.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: