Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voip integration #90945

Merged
merged 26 commits into from
Apr 12, 2023
Merged

Voip integration #90945

merged 26 commits into from
Apr 12, 2023

Conversation

synesthesiam
Copy link
Contributor

Breaking change

Proposed change

Add voice over IP (VoIP) integration for use with phones connected to a Grandstream (HT801/HT802).
Runs pipeline for configured language in a loop, taking in STT commands and responding with TTS.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 6, 2023

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Apr 6, 2023

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (voice_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of voice_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign voice_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@synesthesiam synesthesiam force-pushed the voip-integration branch 2 times, most recently from b25cf0b to 7ddef47 Compare April 6, 2023 20:21
@synesthesiam synesthesiam marked this pull request as ready for review April 7, 2023 03:16
@balloob balloob merged commit 78fec33 into dev Apr 12, 2023
@balloob balloob deleted the voip-integration branch April 12, 2023 00:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
_LOGGER = logging.getLogger(__name__)
_IP_WILDCARD = "0.0.0.0"

__all__ = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only needed if another integration will import names from this integration. I don't think that's the case here. We can remove it.

asyncio.DatagramProtocol,
],
) -> asyncio.DatagramTransport:
transport, _protocol = await hass.loop.create_datagram_endpoint(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like something that should be done in a 3rd party library.

https://developers.home-assistant.io/docs/creating_component_code_review#4-communication-with-devicesservices

Abstract the asyncio datagram protocol interface so the library user doesn't need to know about that detail.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants