Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android TV Remote: Bump androidtvremote2==0.0.7 #91001

Merged
merged 8 commits into from
Apr 8, 2023

Conversation

tronikos
Copy link
Member

@tronikos tronikos commented Apr 7, 2023

Proposed change

Actually fix tronikos/androidtvremote2#2 since previous fix only worked on some devices
tronikos/androidtvremote2@v0.0.5...v0.0.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@Drafteed Drafteed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сan confirm. This fixes issue with disconnect 👍.

Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. But if the only reason is to log the disconnect, why doesnt the library just log that on debug level?

@tronikos
Copy link
Member Author

tronikos commented Apr 7, 2023

The library already debug logs exceptions. I included it here to help in any disconnect issues without enabling debugging. But I just realized why I didn't initially do that. The requirement for silver says: "It will not print any exceptions nor will it fill the log with retry attempts." I guess this now violates that, right? Or is it fine if I'm only logging the message and not stacktrace?

@tronikos tronikos changed the title Android TV Remote: Log exception that caused disconnect Android TV Remote: Bump androidtvremote2==0.0.7 Apr 8, 2023
@tronikos
Copy link
Member Author

tronikos commented Apr 8, 2023

I removed the exception logging to not violate the silver requirement. So this is just bumping the dependency to fix the linked issue. Thanks @Drafteed for confirming this fixes it.

@elupus
Copy link
Contributor

elupus commented Apr 8, 2023

I think the main requirement from silver is to not log bactraces. Logging a stringified error based on the exception is fine.

@elupus elupus merged commit 6c7f216 into home-assistant:dev Apr 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants