-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android TV Remote: Bump androidtvremote2==0.0.7 #91001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сan confirm. This fixes issue with disconnect 👍.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me. But if the only reason is to log the disconnect, why doesnt the library just log that on debug level?
The library already debug logs exceptions. I included it here to help in any disconnect issues without enabling debugging. But I just realized why I didn't initially do that. The requirement for silver says: "It will not print any exceptions nor will it fill the log with retry attempts." I guess this now violates that, right? Or is it fine if I'm only logging the message and not stacktrace? |
I removed the exception logging to not violate the silver requirement. So this is just bumping the dependency to fix the linked issue. Thanks @Drafteed for confirming this fixes it. |
I think the main requirement from silver is to not log bactraces. Logging a stringified error based on the exception is fine. |
Proposed change
Actually fix tronikos/androidtvremote2#2 since previous fix only worked on some devices
tronikos/androidtvremote2@v0.0.5...v0.0.7
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: