Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obihai to have common unique_ids with DHCP or without #91239

Merged
merged 3 commits into from May 31, 2023

Conversation

ejpenney
Copy link
Contributor

@ejpenney ejpenney commented Apr 11, 2023

Proposed change

DHCP Info and PyObihai.get_device_mac have different casing, so depending on the setup path, users can sometimes see DHCP discovery for an already configured device. Everything now uses format_mac(), for consitency.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #92625
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dshokouhi, mind taking a look at this pull request as it has been labeled with an integration (obihai) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of obihai can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign obihai Removes the current integration label and assignees on the pull request, add the integration domain after the command.

epenet
epenet previously requested changes Apr 12, 2023
homeassistant/components/obihai/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/obihai/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/obihai/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/obihai/config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 12, 2023 05:38
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ejpenney ejpenney marked this pull request as ready for review April 12, 2023 15:09
@home-assistant home-assistant bot requested a review from epenet April 12, 2023 15:09
@epenet epenet dismissed their stale review April 12, 2023 16:17

Comments addressed

@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Apr 12, 2023
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Please adjust the PR description now that the standardisation rule has changed.

@ejpenney ejpenney changed the title Obihai differing unique_ids with DHCP Obihai to have common unique_ids with DHCP or without Apr 26, 2023
@ejpenney ejpenney force-pushed the ejpenney_dhcp_case_mismatch branch from 7631db5 to 69ecb9b Compare May 27, 2023 04:11
@balloob balloob merged commit 9eac045 into home-assistant:dev May 31, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cla-signed integration: obihai Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obihai Obitalk integration shows as newly discovered, when its already configured.
4 participants