Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inovelli Blue Series switch support in ZHA #91254

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Update Inovelli Blue Series switch support in ZHA #91254

merged 6 commits into from
Apr 12, 2023

Conversation

codyhackw
Copy link
Contributor

Breaking change

Proposed change

This PR updates the Inovelli Blue Series switch support in ZHA to account for changes here: https://github.com/zigpy/zha-device-handlers/pull/2334/files

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@puddly
Copy link
Contributor

puddly commented Apr 11, 2023

Does this change depend on a specific firmware version? I notice a few attributes were renamed but their IDs are reused.

@codyhackw
Copy link
Contributor Author

The additional parameters come in with the 2.14 firmware that was just released, the renamed attributes are also matching the PR for ZHA so it'll only be dependent on staying in sync with the new names there for prior firmware versions.

Essentially they put a double tap scene into firmware so this covers that new way and should keep the previous way working as well.

@puddly puddly mentioned this pull request Apr 12, 2023
20 tasks
@puddly puddly added this to the 2023.4.3 milestone Apr 12, 2023
@frenck frenck merged commit 4f507e7 into home-assistant:dev Apr 12, 2023
balloob pushed a commit that referenced this pull request Apr 13, 2023
Co-authored-by: David F. Mulcahey <david.mulcahey@icloud.com>
@balloob balloob mentioned this pull request Apr 13, 2023
tkhadimullin pushed a commit to tkhadimullin/ha-core that referenced this pull request Apr 13, 2023
Co-authored-by: David F. Mulcahey <david.mulcahey@icloud.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants