Add a guard against selecting all entities in state_changes_during_period

[bdraco]

Proposed change

If an entity id that doesn't exist was passed to state_changes_during_period we would return history for all entities during the period because the filter would not be applied. In some cases this could be 100000 of rows.

It was too easy to accidentally select all entity ids which is exactly what is happening here.

This cannot happen in dev/2023.5.x because we require entity ids after #90992 because we were worried about this case. The change in dev is not back-portable so this PR is to rc

In the report below, a history stats sensor for a non-existent entity id is what triggered the issue
https://discord.com/channels/330944238910963714/332167321311510530/1097789540657266758

We have tests for this case in dev that were added as part of #90992 but thats not in 2023.4.x The tests can't be backported because the design has changed.

This is effectively

core/homeassistant/components/recorder/history/modern.py

Line 392 in f49dc65

if not (

for rc

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign recorder Removes the current integration label and assignees on the pull request, add the integration domain after the command.