Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lakeside to 0.13 #92173

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

nkgilley
Copy link
Contributor

@nkgilley nkgilley commented Apr 28, 2023

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare
Copy link
Member

I just noticed that your fork is still connected to the archived repo. It's nice to disconnect it to make it easier to compare releases etc. Maybe it's under way at github, if you asked them already?

lakeside

@MartinHjelmare
Copy link
Member

I added a github commit diff link to the PR description.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2023.5.0 milestone Apr 28, 2023
@nkgilley
Copy link
Contributor Author

I just noticed that your fork is still connected to the archived repo. It's nice to disconnect it to make it easier to compare releases etc. Maybe it's under way at github, if you asked them already?

lakeside

I'll request the disconnect now.

@MartinHjelmare MartinHjelmare merged commit c3d3bc4 into home-assistant:dev Apr 28, 2023
frenck pushed a commit that referenced this pull request Apr 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eufy integration no longer working after upgrading supervisor to 2023.04.0
3 participants