Allow exposing entities not in the entity registry to assistants #92363

emontnemery · 2023-05-02T13:01:39Z

Proposed change

Allow exposing entities not in the entity registry to assistants

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2023-05-02T13:01:48Z

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (google_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_assistant can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign google_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant · 2023-05-02T13:01:49Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign homeassistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant · 2023-05-02T13:01:49Z

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant · 2023-05-02T13:01:49Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (switch_as_x) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switch_as_x can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign switch_as_x Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant · 2023-05-02T13:01:50Z

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant · 2023-05-02T13:01:50Z

Hey there @home-assistant/cloud, @ochlocracy, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration (alexa) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of alexa can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign alexa Removes the current integration label and assignees on the pull request, add the integration domain after the command.

jbouwh

Looks good for Alexa. Tried the PR with some yaml entities without unique ID which worked fine.

homeassistant/components/homeassistant/exposed_entities.py

frenck · 2023-05-02T16:58:16Z

If all assistants are marked as "not exposed", like this one:

Should it be removed from the storage collection instead?

The frontend doesn't show this one anymore at this point.
The exact same happens when removing the entity from the frontend.

(can be a later / smaller cleanup thought)

bramkragten · 2023-05-02T17:07:03Z

Getting:

home-assistant/core/homeassistant/components/google_assistant/report_state.py:66: RuntimeWarning: coroutine 'CloudGoogleConfig.should_expose' was never awaited
  if not google_config.should_expose(new_state):
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

emontnemery · 2023-05-02T17:12:14Z

If all assistants are marked as "not exposed", like this one:

Should it be removed from the storage collection instead?

The frontend doesn't show this one anymore at this point. The exact same happens when removing the entity from the frontend.

(can be a later / smaller cleanup thought)

No, in case the user has enabled automatic expose of supported entities, the choice to not expose an entity needs to be stored.

frenck · 2023-05-02T17:39:06Z

No, in case the user has enabled automatic expose of supported entities, the choice to not expose an entity needs to be stored.

In that case, we have a frontend issue @bramkragten, if the case described above is true, it should also show up as such in the UI? Right now, there is no difference in the UI between the choice made to automatic expose or explicitly disabled expose in that case.

emontnemery · 2023-05-02T17:47:17Z

No, in case the user has enabled automatic expose of supported entities, the choice to not expose an entity needs to be stored.

In that case, we have a frontend issue @bramkragten, if the case described above is true, it should also show up as such in the UI? Right now, there is no difference in the UI between the choice made to automatic expose or explicitly disabled expose in that case.

The UI shows exposed entities, and the list shows the exposed entities, what's the problem?

jbouwh

Okay with alexa and google_assistant (test config via yaml with items without a unique id).

)

DavidFW1960 · 2023-05-02T23:17:35Z

So I can now expose mt LimitlessLED lights (need to use the bottom right + Expose Entities option and they are there but

And the message is not supported by this assistant

balloob · 2023-05-03T01:19:06Z

homeassistant/components/homeassistant/exposed_entities.py

+    def _create_item(self, item_id: str, data: dict) -> ExposedEntity:
+        """Create an item from validated config."""
+        del data["entity_id"]
+        return ExposedEntity(**data)


We should always name all the keys as we otherwise don't allow rolling back.

Allow exposing entities not in the entity registry to assistants

526c27d

emontnemery added this to the 2023.5.0 milestone May 2, 2023

emontnemery requested review from a team, synesthesiam, ochlocracy and jbouwh as code owners May 2, 2023 13:01

home-assistant bot added cla-signed core has-tests integration: alexa integration: cloud integration: conversation integration: google_assistant integration: homeassistant integration: switch_as_x labels May 2, 2023

home-assistant bot added Quality Scale: No score Quality Scale: internal labels May 2, 2023

home-assistant bot assigned ochlocracy May 2, 2023

home-assistant bot added the Quality Scale: internal label May 2, 2023

home-assistant bot assigned synesthesiam May 2, 2023

home-assistant bot assigned jbouwh May 2, 2023

jbouwh approved these changes May 2, 2023

View reviewed changes

Add backwards compatibility with beta

c0786f0

Update conversation setup

d64cffc

bramkragten mentioned this pull request May 2, 2023

Update expose for entities not in the entity registry home-assistant/frontend#16377

Merged

9 tasks

frenck reviewed May 2, 2023

View reviewed changes

homeassistant/components/homeassistant/exposed_entities.py Show resolved Hide resolved

Add missing await

8ae81aa

Update tests

f8460db

emontnemery requested a review from bdraco as a code owner May 2, 2023 17:46

jbouwh approved these changes May 2, 2023

View reviewed changes

emontnemery added 2 commits May 2, 2023 20:33

Update tests

f0f7cec

Update tests

6de4481

bramkragten mentioned this pull request May 2, 2023

Update frontend to 20230502.0 #92373

Merged

frenck approved these changes May 2, 2023

View reviewed changes

frenck merged commit e3c16e6 into dev May 2, 2023

frenck deleted the expose_any_entity branch May 2, 2023 20:08

frenck added the cherry-picked label May 2, 2023

frenck pushed a commit that referenced this pull request May 2, 2023

Allow exposing entities not in the entity registry to assistants (#92363

5b1278d

)

pgsylvestre mentioned this pull request May 2, 2023

YAML defined Climate Devices can no longer be configured for use with Voice Assistants #92351

Closed

balloob reviewed May 3, 2023

View reviewed changes

github-actions bot locked and limited conversation to collaborators May 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow exposing entities not in the entity registry to assistants #92363

Allow exposing entities not in the entity registry to assistants #92363

emontnemery commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

jbouwh left a comment

frenck commented May 2, 2023 •

edited

Loading

bramkragten commented May 2, 2023

emontnemery commented May 2, 2023 •

edited

Loading

frenck commented May 2, 2023

emontnemery commented May 2, 2023

jbouwh left a comment

DavidFW1960 commented May 2, 2023

balloob May 3, 2023

Allow exposing entities not in the entity registry to assistants #92363

Allow exposing entities not in the entity registry to assistants #92363

Conversation

emontnemery commented May 2, 2023

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

home-assistant bot commented May 2, 2023

jbouwh left a comment

Choose a reason for hiding this comment

frenck commented May 2, 2023 • edited Loading

bramkragten commented May 2, 2023

emontnemery commented May 2, 2023 • edited Loading

frenck commented May 2, 2023

emontnemery commented May 2, 2023

jbouwh left a comment

Choose a reason for hiding this comment

DavidFW1960 commented May 2, 2023

balloob May 3, 2023

Choose a reason for hiding this comment

frenck commented May 2, 2023 •

edited

Loading

emontnemery commented May 2, 2023 •

edited

Loading