-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Airzone climate code #93515
Improve Airzone climate code #93515
Conversation
This makes the code more robust against unavaialable device issues. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill in the PR description to explain why this is an improvement
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Does it mean the library may return some unexpected value? Should that be logged? |
I've only seen it return |
OK, I see. Then I think the code in the PR is OK, but please add some comments explaining the get. |
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Done in e8b965e |
With the changes done in the library and in the integration in the following PR this is no longer needed: |
Proposed change
This makes the code more robust for those cases where the key isn't found on the translation dicts.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: