Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aioairzone to v0.6.1 #93629

Merged
merged 2 commits into from May 27, 2023
Merged

Update aioairzone to v0.6.1 #93629

merged 2 commits into from May 27, 2023

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented May 26, 2023

Proposed change

Update aioairzone to v0.6.1.
The code has been refactored and improved and now the library will detect when a zone disappears from the API and will set AZD_AVAILABLE to False in that case. This happened to me when one of my thermostats ran out of battery and the API stopped providing its data.

Releases:

Git compare: Noltari/aioairzone@0.5.6...0.6.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari mentioned this pull request May 27, 2023
20 tasks
@@ -130,6 +136,11 @@ def __init__(
)
self._attr_unique_id = entry.unique_id or entry.entry_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AirzoneSystemEntity and AirzoneZoneEntity almost look like they share enough to have a common base class

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Noltari

@bdraco bdraco merged commit 94ad964 into home-assistant:dev May 27, 2023
52 checks passed
@Noltari Noltari deleted the airzone-v0.6.1 branch May 28, 2023 08:04
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants