Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time component to Melnor Bluetooth integration #93652

Merged
merged 2 commits into from May 31, 2023

Conversation

vanstinator
Copy link
Contributor

@vanstinator vanstinator commented May 27, 2023

Proposed change

Following up on the scheduler support in #93333 this PR adds the final missing piece: time support for setting the start time of the frequency schedule.

This change includes a bugfix bump to the melnor-bluetooth library to fix some date handling around schedules vanstinator/melnor-bluetooth@v0.0.21...v0.0.22

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@vanstinator
Copy link
Contributor Author

vanstinator commented May 31, 2023

Thanks for grabbing the fixups too! ❤️

@balloob balloob merged commit 4bade86 into home-assistant:dev May 31, 2023
52 checks passed
@vanstinator vanstinator deleted the feature/melnor-time branch May 31, 2023 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants