Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time component to melnor documentation #27553

Merged
merged 1 commit into from
May 31, 2023

Conversation

vanstinator
Copy link
Contributor

Proposed change

I've added support for the built-in scheduling feature of the Melnor Bluetooth watering valves. As part of this work, I've added support for the brand new time component, which needs to be added to the documentation here.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels May 27, 2023
@vanstinator
Copy link
Contributor Author

I'm not a technical writer, so I'm open to suggestions here:

Should I list out what features that HA supports? The valve offers 2 different scheduling types, the work I've done recently adds support for one of them. The valves also offer rain delays, eco watering modes, and support a soil moisture sensor: none of which we support.

The current docs feel a bit light and I think there's room for another PR that fleshes some of this out.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vanstinator 👍

../Frenck

@frenck frenck merged commit bec1936 into home-assistant:next May 31, 2023
8 checks passed
@vanstinator vanstinator deleted the melnor_time branch May 31, 2023 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants