-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Ezviz detection sensitivity to update per entity #93995
Change Ezviz detection sensitivity to update per entity #93995
Conversation
Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should we tag this for the June release? |
…nt#93995) * Split detection sensitivity updates to entity instead of coordinator. * Detection Sensitivity entity individual poll. * Api return None instead of "unkown" when unkown. * Only add entity if camera supports * Cleanup detection type * Commit suggestions. --------- Co-authored-by: Chris Talkington <chris@talkingtontech.com>
Removing this from milestone because it relies on a dependency bump of #93710 and it's unclear if that can just be included. |
Proposed change
The entity is now responsible for querying detection sensitivity of the camera.
Had to bump dependency for this:
Compare: BaQs/pyEzviz@0.2.0.15...0.2.0.17
Releases: https://github.com/BaQs/pyEzviz/releases
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: