Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Ezviz detection sensitivity to update per entity #93995

Conversation

RenierM26
Copy link
Contributor

@RenierM26 RenierM26 commented Jun 3, 2023

Proposed change

The entity is now responsible for querying detection sensitivity of the camera.

  • This allows the user to disable querying per device entity.
  • Results in a drastic speed increase due to simultaneous requests.
  • Reduced API timeouts. (Especially if user has multiple cameras)

Had to bump dependency for this:

Compare: BaQs/pyEzviz@0.2.0.15...0.2.0.17
Releases: https://github.com/BaQs/pyEzviz/releases

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 3, 2023

Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration (ezviz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ezviz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ezviz Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@MartinHjelmare MartinHjelmare changed the title Change Ezviz detection sensitivity to update per entity. Change Ezviz detection sensitivity to update per entity Jun 5, 2023
homeassistant/components/ezviz/number.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/number.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/number.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Jun 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 5, 2023 05:58
@RenierM26 RenierM26 marked this pull request as ready for review June 5, 2023 16:13
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

Should we tag this for the June release?

@MartinHjelmare MartinHjelmare merged commit 6af1beb into home-assistant:dev Jun 7, 2023
51 of 52 checks passed
@MartinHjelmare MartinHjelmare added this to the 2023.6.1 milestone Jun 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
@balloob
Copy link
Member

balloob commented Jun 8, 2023

Removing this from milestone because it relies on a dependency bump of #93710 and it's unclear if that can just be included.

@balloob balloob removed this from the 2023.6.1 milestone Jun 8, 2023
@home-assistant home-assistant unlocked this conversation Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
@RenierM26 RenierM26 deleted the ezviz_detection_sensitivity_to_entity branch July 16, 2023 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ezviz integration does not handle 2 Ezviz cameras being put into Sleep mode
4 participants