Fix ruckus_unleashed for python 3.11

[lanrat]

Breaking change

Proposed change

Due to lack of Python 3.11 support for the pyruckus library, switching to using the newer and better aioruckus library that support Python 3.11.

This fix was made with the help of @ms264556 and is heavily based on a prior PR they had made.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes ruckus_unleashed: integration "Failed to set up" on 2023.6.0 #94264
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @gabe565, mind taking a look at this pull request as it has been labeled with an integration (ruckus_unleashed) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ruckus_unleashed can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign ruckus_unleashed Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[frenck]

We require a 100% test coverage for the configuration flow, however these tests have been removed in this PR.

Therefore, this PR cannot be reviewed or merged in its current state.

../Frenck

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[pcmoore]

Hi @frenck, is there any chance you might be able to help with the tests in the PR? In the original problem report @lanrat has mentioned that he needs some help to resolve the testing issues and sadly the rest of us who are affected simply don't have the Python/HA background to provide that help.

The Ruckus Unleashed integration has been broken for all users since the 2023.6.0 release and I would really hate to see this continue into another monthly release. Any help you can provide @frenck would be really appreciated!

[pcmoore]

Please see the above @gabe565, any chance you could help us out?

[ms264556]

I structured the library so it followed the recommendations here: https://developers.home-assistant.io/docs/api_lib_index/ : aiohttp.ClientSession > aioruckus.AjaxSession > aioruckus.RuckusAjaxApi.

For this style of library, is there a sample or any gold-standard implementation which I can crib to implement the required config flow tests?

[pcmoore]

At this point I have to assume the Ruckus integration is going to continue to be broken for some time while we wait for some help getting the tests to pass CI. While we are waiting, would it be possible to update the page for the integration to say that it is currently broken? It might help new users make a more informed decision about which integrations are available ...

• https://www.home-assistant.io/integrations/ruckus_unleashed

[lanrat]

I did a force-push to address the CLA email error.

[ms264556]

@lanrat you marked it as "ready for review" a little prematurely. I had problems running the tests inside the home assistant codespace, and had to install docker desktop and setup a devcontainer. Tests are passing now, and I was able to run HA and track a ruckus_unleashed client entity.

[lanrat]

@lanrat you marked it as "ready for review" a little prematurely. I had problems running the tests inside the home assistant codespace, and had to install docker desktop and setup a devcontainer. Tests are passing now, and I was able to run HA and track a ruckus_unleashed client entity.

Oops. let me know if you want me to convert it back to draft.

[edenhaus]

Please revert any feature changes to keep this PR small. These features can be moved into a follow-up PR, including the required migration.

[ms264556]

Hi @lanrat could you mark this as ready for review again?

[edenhaus]

Thanks @lanrat @ms264556 👍

Changes addressed

[MartinHjelmare]

Please address the comments in a new PR. Thanks!

[MartinHjelmare]

I'm missing an update to the translation strings.json file for the reauth confirm step and abort reauth success.