Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address ruckus_unleashed late review #99411

Merged
merged 11 commits into from Sep 10, 2023
Merged

Address ruckus_unleashed late review #99411

merged 11 commits into from Sep 10, 2023

Conversation

ms264556
Copy link
Contributor

@ms264556 ms264556 commented Aug 31, 2023

Proposed change

This is a followup to PR Fix ruckus_unleashed for python 3.11 #94583 , to address bugs found by MartinHjelmare.

PR #94583 fixes broken ruckus_unleashed integration by switching to the aioruckus library that support Python 3.11.

Updated aioruckus dependency: v0.31 > v0.34

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @gabe565, @lanrat, mind taking a look at this pull request as it has been labeled with an integration (ruckus_unleashed) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ruckus_unleashed can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ruckus_unleashed Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 31, 2023 18:29
@ms264556 ms264556 marked this pull request as ready for review September 1, 2023 04:00
@home-assistant home-assistant bot marked this pull request as draft September 1, 2023 09:03
@lanrat
Copy link
Contributor

lanrat commented Sep 1, 2023

@MartinHjelmare just a heads up, I told @ms264556 that they are welcome to add themselves as a codeowner if they wanted to since they are helping so much with this integration.

@ms264556 ms264556 marked this pull request as ready for review September 4, 2023 19:41
@MartinHjelmare
Copy link
Member

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per comments above.

@home-assistant home-assistant bot marked this pull request as draft September 7, 2023 09:16
@ms264556 ms264556 marked this pull request as ready for review September 7, 2023 13:17
@MartinHjelmare
Copy link
Member

Looks good! Just one remaining question:
#99411 (comment)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Fix ruckus_unleashed for python 3.11, round 2 Address ruckus_unleashed late review Sep 10, 2023
@MartinHjelmare MartinHjelmare merged commit 3b25262 into home-assistant:dev Sep 10, 2023
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
@ms264556 ms264556 deleted the ruckus_unleashed_py3.11 branch September 13, 2023 01:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants