New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address ruckus_unleashed late review #99411
Address ruckus_unleashed late review #99411
Conversation
Hey there @gabe565, @lanrat, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@MartinHjelmare just a heads up, I told @ms264556 that they are welcome to add themselves as a codeowner if they wanted to since they are helping so much with this integration. |
Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per comments above.
Looks good! Just one remaining question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
This is a followup to PR Fix ruckus_unleashed for python 3.11 #94583 , to address bugs found by MartinHjelmare.
PR #94583 fixes broken ruckus_unleashed integration by switching to the aioruckus library that support Python 3.11.
Updated aioruckus dependency: v0.31 > v0.34
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: