Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce overhead to update esphome entities #94930

Merged
merged 12 commits into from
Jun 21, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 20, 2023

Proposed change

Reduce overhead to update esphome entities

There were lots of property/attrs lookups for static info values that rarely change. We can update the attrs when we get the dispatch instead.

I also changed the recently added _on_static_info_update to dispatch indexed by component_key and key to avoid the pattern where each entity has to reject the dispatch if it doesn't match the key

I did sensor first since power sensors are usually one or two orders of magnitude more updates than anything else. I also did binary_sensor to make sure the pattern would work beyond just sensor since it was the simplest platform to modify and it had special cases for the connected sensor

Also pickup codeowner for esphome to make sure this doesn't have any unexpected fallout and since I've been working through a lot of the esphome issues in the queue anyways.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco mentioned this pull request Jun 20, 2023
20 tasks
@bdraco
Copy link
Member Author

bdraco commented Jun 20, 2023

Reflashed a few to make sure the behavior is the same

@bdraco bdraco marked this pull request as ready for review June 20, 2023 19:20
@bdraco
Copy link
Member Author

bdraco commented Jun 20, 2023

esphome_static_info_reduce_remain does the other platforms but I'm going to split them into multiple PRs as I don't have production use cases for all entity types so I'm only going to move forward the ones I can test manually or have coverage already

@frenck frenck merged commit 804a8ef into dev Jun 21, 2023
20 checks passed
@frenck frenck deleted the esphome_static_info_reduce branch June 21, 2023 09:00
@bdraco
Copy link
Member Author

bdraco commented Jun 21, 2023

thanks

bdraco added a commit that referenced this pull request Jun 21, 2023
bdraco added a commit that referenced this pull request Jun 21, 2023
bdraco added a commit that referenced this pull request Jun 21, 2023
bdraco added a commit that referenced this pull request Jun 21, 2023
bdraco added a commit that referenced this pull request Jun 21, 2023
bdraco added a commit that referenced this pull request Jun 21, 2023
bdraco added a commit that referenced this pull request Jun 21, 2023
bdraco added a commit that referenced this pull request Jun 22, 2023
followup to #94930

was waiting for #95023 since I have no production lock entities
bdraco added a commit that referenced this pull request Jun 22, 2023
followup to #94930

was waiting for #95025 since I have no production fan entities
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants