Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tuya Smart Water Timer #95053

Merged
merged 18 commits into from Nov 29, 2023
Merged

Add Tuya Smart Water Timer #95053

merged 18 commits into from Nov 29, 2023

Conversation

syepes
Copy link
Contributor

@syepes syepes commented Jun 22, 2023 •
edited

Breaking change

None

Proposed change

Adds support for Smart Water Timers from Tuya
This an updated version of #69188 and adds only the working elements

R4238 Smart Irrigation Control
https://wooxhome.com/products-c10/other-c4/woox-r4238-smart-garden-irrigation-control-p107

TUYA Integration: Added support for Moes Smart Water Timer
https://user-images.githubusercontent.com/795322/135816004-3268df58-b7e4-48d2-bbf7-cb40f481b234.jpg

https://www.moeshouse.com/products/smart-bluetooth-sprinkler-water-timer-with-rain-delay-filter-washer-programmable-irrigation-timer-with-automatic-and-manual-watering-for-standard-outdoor-garden-faucet-lawn-bluetooth-hub-required-for-irrigation-history

Standard Status Set

CleanShot 2023-09-08 at 12 42 47 CleanShot 2023-09-08 at 12 43 18

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

None

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@syepes syepes requested a review from frenck as a code owner June 22, 2023 11:32
@home-assistant
Copy link

Hi @syepes

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@syepes
Copy link
Contributor Author

syepes commented Jun 22, 2023

@frenck Any change we could get this reviewed, this is really simple modification.

@frenck
Copy link
Member

frenck commented Jun 22, 2023 •
edited

@frenck Any change we could get this reviewed, this is really simple modification.

This PR has been open for just 7 hours (5 hours since your last comment), and you think it takes too long and it is time ping people? Please... don't do that.

See also: https://developers.home-assistant.io/docs/review-process#what-not-to-do

@frenck frenck changed the title Add Tuya Smart Water Timer (NEW) Add Tuya Smart Water Timer Jun 22, 2023
@frenck
Copy link
Member

frenck commented Jun 27, 2023

Why do you keep merging dev into this PR? Was there a conflict? An upstream change the affected this PR?

It is good to be a little up-to-date, but you really don't have to merge constantly.
It causes notifications, causes the CI to be approved again, and wastes resources on running the CI unneeded.

../Frenck

@syepes

This comment was marked as off-topic.

Sign in to view
@brainexe brainexe mentioned this pull request Jul 13, 2023
Closed
20 tasks
@syepes syepes mentioned this pull request Jul 13, 2023
Closed
@blackbird0589

This comment was marked as off-topic.

Sign in to view
@kl4ver

This comment was marked as off-topic.

Sign in to view
@frenck
Copy link
Member

frenck commented Jul 20, 2023

Please do demand and ping for reviews. The queue is large. Please see our developer documentation for information on our review process (and on what not to do...).

../Frenck

@syepes

This comment was marked as off-topic.

Sign in to view
@Cabbina

This comment was marked as off-topic.

Sign in to view
@frenck frenck marked this pull request as draft October 29, 2023 16:45
@syepes syepes marked this pull request as ready for review October 31, 2023 07:01
@syepes
Copy link
Contributor Author

syepes commented Oct 31, 2023

Hopefully this can now be merged :-)

@syepes
Copy link
Contributor Author

syepes commented Nov 1, 2023

Some comments, could you also attach a diagnostic dump of the device? As it isn't documented.

@frenck This is the diagnostic dump hope we can get this integrated :-)
tuya-ae69f8e229b24c007d1ab7227c324fb4-R4238 Smart Irrigation Control.json

Thanks!

@Cabbina

This comment was marked as off-topic.

Sign in to view
@Cabbina

This comment was marked as off-topic.

Sign in to view
@syepes
Copy link
Contributor Author

syepes commented Nov 14, 2023

Thanks

@Cabbina

This comment was marked as off-topic.

Sign in to view
@syepes

This comment was marked as outdated.

Sign in to view
emontnemery
emontnemery previously requested changes Nov 27, 2023
View reviewed changes
homeassistant/components/tuya/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 27, 2023 18:13
frenck
frenck reviewed Nov 28, 2023
View reviewed changes
homeassistant/components/tuya/select.py Show resolved Hide resolved
homeassistant/components/tuya/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/tuya/switch.py Outdated Show resolved Hide resolved
@syepes syepes marked this pull request as ready for review November 28, 2023 22:32
frenck
frenck approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @syepes 👍

../Frenck

@frenck frenck dismissed emontnemery’s stale review November 29, 2023 08:48

Comments addressed

@frenck frenck merged commit a3bad54 into home-assistant:dev Nov 29, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@daniel-simpson daniel-simpson daniel-simpson approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery

Assignees

@frenck frenck

Labels
cla-signed integration: tuya new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@syepes @frenck @blackbird0589 @kl4ver @Cabbina @daniel-simpson @emontnemery