Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Python 3.4 support #9684

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Deprecate Python 3.4 support #9684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7868dfa
Deprecate Python 3.4 support
balloob Oct 4, 2017
5c7f080
Update text
balloob Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions homeassistant/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,18 @@ def async_from_config_dict(config: Dict[str, Any],
This method is a coroutine.
"""
start = time()

if enable_log:
async_enable_logging(hass, verbose, log_rotate_days, log_file)

if sys.version_info[:2] < (3, 5):
_LOGGER.warning(
'Python 3.4 support has been deprecated and will be removed in '
'the begining of 2018. Please upgrade Python or your operating '
'system. More info: https://home-assistant.io/blog/2017/10/06/'
'deprecating-python-3.4-support/'
)

core_config = config.get(core.DOMAIN, {})

try:
Expand All @@ -93,9 +105,6 @@ def async_from_config_dict(config: Dict[str, Any],

yield from hass.async_add_job(conf_util.process_ha_config_upgrade, hass)

if enable_log:
async_enable_logging(hass, verbose, log_rotate_days, log_file)

hass.config.skip_pip = skip_pip
if skip_pip:
_LOGGER.warning("Skipping pip installation of required modules. "
Expand Down