Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Python 3.4 support #9684

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Deprecate Python 3.4 support #9684

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7868dfa
Deprecate Python 3.4 support
balloob Oct 4, 2017
5c7f080
Update text
balloob Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions homeassistant/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ def async_from_config_dict(config: Dict[str, Any],
This method is a coroutine.
"""
start = time()

if enable_log:
async_enable_logging(hass, verbose, log_rotate_days, log_file)

if sys.version_info[:2] < (3, 5):
_LOGGER.warning('Python 3.4 support has been deprecated and will be '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rephrase this to represent the change for the common user a bit more?
Python 3.4 support has been deprecated and will be
removed in the beginning of 2018.
Please upgrade Python or your chosen distribution.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not sure if this is overkill, but it would be nice to link to a blog post or a doc where we can explain why support is being dropped, and direct users to further resources for different distros. Especially as we get a broader audience, not everyone is going to understand what this means.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The why of dropping of support is not super important to me as opposed to how I can to switch to Python 3.5, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the platforms there are already install guides, it would be good to detail whether an upgrade is possible, and if so how.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't add upgrade instructions for every platform. I'll add a link to the blog post and the blog post will contain instructions for Hassbian. If people don't use our recommended platforms, they are on their own.

'removed in 2018. Please upgrade Python.')

core_config = config.get(core.DOMAIN, {})

try:
Expand All @@ -93,9 +101,6 @@ def async_from_config_dict(config: Dict[str, Any],

yield from hass.async_add_job(conf_util.process_ha_config_upgrade, hass)

if enable_log:
async_enable_logging(hass, verbose, log_rotate_days, log_file)

hass.config.skip_pip = skip_pip
if skip_pip:
_LOGGER.warning("Skipping pip installation of required modules. "
Expand Down