Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AVM Fritz!Smarthome as Gold integration #97086

Merged

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jul 23, 2023

Proposed change

Marks the AVM Fritz!Smarthome integration as Gold on the integration quality scale.

Silver πŸ₯ˆ

  • βœ… Satisfying all No score level requirements.
  • βœ… Connection/configuration is handled via a component.
  • βœ… Set an appropriate SCAN_INTERVAL (if a polling integration)
  • βœ… Raise PlatformNotReady if unable to connect during platform setup (if appropriate)
  • βœ… Handles expiration of auth credentials. Refresh if possible or print correct error and fail setup. If based on a config entry, should trigger a new config entry flow to re-authorize. (docs)
  • βœ… Handles internet unavailable. Log a warning once when unavailable, log once when reconnected.
  • βœ… Handles device/service unavailable. Log a warning once when unavailable, log once when reconnected.
  • βœ… Operations like service calls and entity methods (e.g. Set HVAC Mode) have proper exception handling. Raise ValueError on invalid user input and raise HomeAssistantError for other failures such as a problem communicating with a device.
  • βœ… Set available property to False if appropriate (docs)
  • βœ… Entities have unique ID (if available) (docs)

Gold πŸ₯‡

  • βœ… Satisfying all Silver level requirements.

  • βœ… Configurable via config entries.

  • βœ… Entities have device info (if available) (docs)

  • βœ… Tests

    • βœ… Full test coverage for the config flow
    • βœ… Above average test coverage for all integration modules
    • βœ… Tests for fetching data from the integration and controlling it (docs)
  • βœ… Has a code owner (docs)

  • βœ… Entities only subscribe to updates inside async_added_to_hass and unsubscribe inside async_will_remove_from_hass (docs)

  • βœ… Entities have correct device classes where appropriate (docs)

  • βœ… Supports entities being disabled and leverages Entity.entity_registry_enabled_default to disable less popular entities (docs)

  • βœ… If the device/service API can remove entities, the integration should make sure to clean up the entity and device registry.

  • βœ… When communicating with a device or service, the integration implements the diagnostics platform which redacts sensitive information.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@mib1185 mib1185 added this to the 2023.9.0 milestone Aug 30, 2023
@balloob balloob merged commit a77f1cb into home-assistant:dev Sep 4, 2023
21 checks passed
bramkragten pushed a commit that referenced this pull request Sep 4, 2023
@mib1185 mib1185 deleted the fritzbox/mark-as-gold-integration branch September 4, 2023 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants